[GitHub] [spark] gaborgsomogyi commented on a change in pull request #29932: [SPARK-33052][SQL][TEST] Make database versions up-to-date for integration tests

[GitBox]

gaborgsomogyi commented on a change in pull request #29932:
URL: https://github.com/apache/spark/pull/29932#discussion_r498689492



##########
File path: 
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/MariaDBKrbIntegrationSuite.scala
##########
@@ -30,7 +30,7 @@ class MariaDBKrbIntegrationSuite extends 
DockerKrbJDBCIntegrationSuite {
   override protected val keytabFileName = "mariadb.keytab"
 
   override val db = new DatabaseOnDocker {
-    override val imageName = "mariadb:10.4"
+    override val imageName = sys.env.getOrElse("MARIADB_DOCKER_IMAGE_NAME", 
"mariadb:10.4")

Review comment:
       I've executed the mentioned test with this PR (`mariadb:10.4`) but it 
works fine on my machine.
   <img width="397" alt="Screenshot 2020-10-02 at 10 23 09" 
src="https://user-images.githubusercontent.com/18561820/94904123-1d1fd700-049b-11eb-8275-74a0f2cc3fd1.png";>
   What I can imagine is that the docker version is different. When I've 
started the development in this area I remember there was quite a stuggle to 
install a working version. I'm still not on the latest.
   <img width="373" alt="Screenshot 2020-10-02 at 10 17 49" 
src="https://user-images.githubusercontent.com/18561820/94904337-7425ac00-049b-11eb-8e3e-f1f8b0b37062.png";>
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org