attilapiros commented on a change in pull request #29855:
URL: https://github.com/apache/spark/pull/29855#discussion_r498833826
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RetryingBlockFetcher.java
##########
@@ -99,18 +99,30 @@ void createAndStart(String[] blockIds,
BlockFetchingListener listener)
*/
private RetryingBlockFetchListener currentListener;
+ private final ErrorHandler errorHandler;
+
public RetryingBlockFetcher(
Review comment:
I think the naming become quite misleading as now block pushings are
retried by this.
I know the changeset is already huge but please consider renaming this in a
follow up PR.
What about `RetryingBlockMover` or `RetryingBlockTransfers`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
