Victsm commented on a change in pull request #29855:
URL: https://github.com/apache/spark/pull/29855#discussion_r498959431
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RetryingBlockFetcher.java
##########
@@ -215,8 +227,11 @@ public void onBlockFetchFailure(String blockId, Throwable
exception) {
if (shouldRetry(exception)) {
initiateRetry();
} else {
- logger.error(String.format("Failed to fetch block %s, and will not
retry (%s retries)",
- blockId, retryCount), exception);
+ if (errorHandler.shouldLogError(exception)) {
+ logger.error(
+ String.format("Failed to fetch block %s, and will not retry
(%s retries)",
Review comment:
Would it be OK to make these changes in the follow up PR?
The RetryingBlockFetcher is filled with many references to "fetch".
I think it would be better to consolidate all these changes in the follow up
PR, which focuses just on this name change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
