HyukjinKwon commented on a change in pull request #29936:
URL: https://github.com/apache/spark/pull/29936#discussion_r499320346



##########
File path: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
##########
@@ -296,8 +296,7 @@ private[hive] class HiveClientImpl(
       case e: NoClassDefFoundError
         if HiveUtils.isHive23 && 
e.getMessage.contains("org/apache/hadoop/hive/serde2/SerDe") =>

Review comment:
       @dongjoon-hyun should we remove `HiveUtils.isHive23` and related 
changes? I see it was added when we add Hive 2.3 support at 
https://github.com/apache/spark/commit/33f3c48cac087e079b9c7e342c2e58b16eaaa681#diff-842e3447fc453de26c706db1cac8f2c4R59.
 cc @wangyum FYI




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to