gaborgsomogyi commented on a change in pull request #29729:
URL: https://github.com/apache/spark/pull/29729#discussion_r499569640
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReader.scala
##########
@@ -563,12 +526,6 @@ private[kafka010] class KafkaOffsetReader(
&& !Thread.currentThread().isInterrupted) {
Thread.currentThread match {
case ut: UninterruptibleThread =>
- // "KafkaConsumer.poll" may hang forever if the thread is
interrupted (E.g., the query
- // is stopped)(KAFKA-1894). Hence, we just make sure we don't
interrupt it.
- //
- // If the broker addresses are wrong, or Kafka cluster is down,
"KafkaConsumer.poll" may
- // hang forever as well. This cannot be resolved in KafkaSource
until Kafka fixes the
- // issue.
Review comment:
There is an agreement to remove uninterruptible thread usage here in the
next commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
