maropu commented on a change in pull request #29065:
URL: https://github.com/apache/spark/pull/29065#discussion_r499574852
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/dynamicpruning/PlanDynamicPruningFilters.scala
##########
@@ -73,18 +90,60 @@ case class PlanDynamicPruningFilters(sparkSession:
SparkSession)
val exchange = BroadcastExchangeExec(mode, executedPlan)
val name = s"dynamicpruning#${exprId.id}"
// place the broadcast adaptor for reusing the broadcast results on
the probe side
- val broadcastValues =
- SubqueryBroadcastExec(name, broadcastKeyIndex, buildKeys, exchange)
- DynamicPruningExpression(InSubqueryExec(value, broadcastValues,
exprId))
+ val broadcastValues = SubqueryBroadcastExec(name, broadcastKeyIndex,
buildKeys, exchange)
+ if (preferBloomFilter(buildKeys(broadcastKeyIndex), buildPlan)) {
+ DynamicPruningExpression(BloomFilterSubqueryExec(value,
broadcastValues, exprId))
Review comment:
Does this PR propose two things: 1. improving the existing part pruning
by bloom filters and 2. implementing a new dynamic pruning strategy (shuffle
pruning)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
