viirya commented on a change in pull request #29942:
URL: https://github.com/apache/spark/pull/29942#discussion_r499834347
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/OptimizeJsonExprs.scala
##########
@@ -28,10 +28,45 @@ import org.apache.spark.sql.types.{ArrayType, StructType}
* The optimization includes:
* 1. JsonToStructs(StructsToJson(child)) => child.
* 2. Prune unnecessary columns from GetStructField/GetArrayStructFields +
JsonToStructs.
+ * 3. CreateNamedStruct(JsonToStructs(json).col1, JsonToStructs(json).col2,
...) =>
+ * CreateNamedStruct(JsonToStructs(json)) if JsonToStructs(json) is
shared among all
+ * fields of CreateNamedStruct.
Review comment:
No, it could be part of the json struct. In the case, we will prune
unnecessary columns in `JsonToStructs`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
