stijndehaes commented on a change in pull request #29934:
URL: https://github.com/apache/spark/pull/29934#discussion_r500002157



##########
File path: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/PodTemplateConfigMapStep.scala
##########
@@ -31,14 +31,16 @@ private[spark] class PodTemplateConfigMapStep(conf: 
KubernetesConf)
 
   private val hasTemplate = conf.contains(KUBERNETES_EXECUTOR_PODTEMPLATE_FILE)
 
+  private val configmapName = 
s"${conf.resourceNamePrefix}-$POD_TEMPLATE_CONFIGMAP"

Review comment:
       Wel actually this configmap is not used by the executors but also by the 
driver. The driver needs this configmap to spawn executors with the right 
template. So I'll change the name to:`driver-podspec-conf-map`. Let me know if 
that is fine.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to