huaxingao commented on a change in pull request #29939:
URL: https://github.com/apache/spark/pull/29939#discussion_r500460870
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
##########
@@ -46,7 +47,8 @@ class UnresolvedException[TreeType <: TreeNode[_]](tree:
TreeType, function: Str
case class UnresolvedRelation(
multipartIdentifier: Seq[String],
options: CaseInsensitiveStringMap = CaseInsensitiveStringMap.empty(),
- override val isStreaming: Boolean = false)
+ override val isStreaming: Boolean = false,
+ partitions: Seq[Partition] = Seq.empty[Partition])
Review comment:
Yes, `partitions` is only for JDBC V2 path, but it seems to me that we
can't use `options` to pass the partition info into JDBC Scan. In
`JDBCTable.newScanBuilder`, it merges `jdbcOptions` with `options` in
`CaseInsensitiveStringMap`, but partitions is not a `JDBCOptions`, so it won't
be passed to `JDBCScanBuilder`. I am not sure if we should add partitions into
`JDBCOptions`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
