srowen commented on pull request #29286: URL: https://github.com/apache/spark/pull/29286#issuecomment-704549676
Either way seems OK to me. All else equal, I prefer to keep one logical change together, as you would not update to sbt 1.x without the other changes, and probably wouldn't take the other changes unless updating to 1.x. I suppose it's easier to reason about as a whole. That said, if the resulting change is pretty large, it's also reasonable to make the separable prerequisite changes first if they work with sbt 0.13.x too. Whatever you prefer, IMHO. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
