dongjoon-hyun commented on a change in pull request #29942:
URL: https://github.com/apache/spark/pull/29942#discussion_r500644314
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/OptimizeJsonExprs.scala
##########
@@ -28,10 +28,45 @@ import org.apache.spark.sql.types.{ArrayType, StructType}
* The optimization includes:
* 1. JsonToStructs(StructsToJson(child)) => child.
* 2. Prune unnecessary columns from GetStructField/GetArrayStructFields +
JsonToStructs.
Review comment:
@viirya . It would be great if we describe `If(IsNull(json),
nullStruct, KnownNotNull(JsonToStructs(prunedSchema1, options, json, ..))`
pattern here because technically it's a new optimized form but not a simplified
one. The existing (1), (2), (3) of this PR doesn't cover it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
