dongjoon-hyun commented on a change in pull request #29877:
URL: https://github.com/apache/spark/pull/29877#discussion_r500666255
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverKubernetesCredentialsFeatureStep.scala
##########
@@ -70,15 +71,8 @@ private[spark] class
DriverKubernetesCredentialsFeatureStep(kubernetesConf: Kube
override def configurePod(pod: SparkPod): SparkPod = {
if (!shouldMountSecret) {
- pod.copy(
- pod = driverServiceAccount.map { account =>
- new PodBuilder(pod.pod)
- .editOrNewSpec()
- .withServiceAccount(account)
- .withServiceAccountName(account)
- .endSpec()
- .build()
- }.getOrElse(pod.pod))
+ pod.copy(pod = buildPodWithServiceAccount(driverServiceAccount, pod)
+ .getOrElse(pod.pod))
Review comment:
Why do we need to split this line? The original code is one-liner in
`master` branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
