HyukjinKwon commented on a change in pull request #29947:
URL: https://github.com/apache/spark/pull/29947#discussion_r500687443



##########
File path: python/pyspark/sql/functions.py
##########
@@ -1592,6 +1592,57 @@ def xxhash64(*cols):
     return Column(jc)
 
 

Review comment:
       Now we should also add it into type hints and documentations at 
https://github.com/apache/spark/blob/master/python/docs/source/reference/pyspark.sql.rst#functions
 and 
https://github.com/apache/spark/blob/master/python/pyspark/sql/functions.pyi. 
cc @zero323 FYI
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to