tanelk commented on a change in pull request #29092:
URL: https://github.com/apache/spark/pull/29092#discussion_r500734180
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -122,6 +122,7 @@ abstract class Optimizer(catalogManager: CatalogManager)
Batch("Operator Optimization before Inferring Filters", fixedPoint,
rulesWithoutInferFiltersFromConstraints: _*) ::
Batch("Infer Filters", Once,
+ InferFiltersFromGenerate,
Review comment:
Actually the `InferFiltersFromConstraints` is allways filtered out from
the `operatorOptimizationRuleSet`:
https://github.com/apache/spark/blob/5ce321dc80a699fa525ca5b69bf2c28e10f8a12a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala#L120-L123
I think it is very misleading , perhaps we could remove it from there and
avoid further confusion?
It was asked in the original PR, put looks like it was forgotten:
https://github.com/apache/spark/pull/19149/files#r157777935
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
