cloud-fan commented on a change in pull request #29913:
URL: https://github.com/apache/spark/pull/29913#discussion_r500794424
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
##########
@@ -587,6 +589,20 @@ object RewriteCorrelatedScalarSubquery extends
Rule[LogicalPlan] {
}
}
}
+ (newChild, AttributeMap(subqueryAttrMapping.toSeq))
+ }
+
+ private def updateAttrs[E <: Expression](
+ exprs: Seq[E],
+ attrMap: AttributeMap[Attribute]): Seq[E] = {
+ if (attrMap.nonEmpty) {
+ val newExprs = exprs.map { _.transform {
+ case a: AttributeReference if attrMap.contains(a) => attrMap(a)
Review comment:
not a big deal: it's more efficient to write `case a: AttributeReference
=> attrMap.getOrElse(a, a)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
