zero323 commented on pull request #29879: URL: https://github.com/apache/spark/pull/29879#issuecomment-704817709
> I personally tend to agree with what you listed up. However, one concern is that it doesn't work well out of the box when the criteria becomes verbose especially for new contributors given my experience - the same criteria is interpreted differently often. So I ended up with focusing on simplifying it unless it's required. Makes sense. I am still thinking about this from a perspective of the main contributor :) > Do the removal of both, for example, cause many ignores? These two have rather limited scope so we're good for now. I didn't to make merge test, but if it becomes a problem later, we can always restore things ‒ stability works both ways here.. > If that's the case, we can keep probably with leaving some comments. Otherwise, let's remove both and start with the simpler set .. Sounds good. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
