stijndehaes commented on a change in pull request #29934:
URL: https://github.com/apache/spark/pull/29934#discussion_r500921364
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/PodTemplateConfigMapStep.scala
##########
@@ -31,14 +31,16 @@ private[spark] class PodTemplateConfigMapStep(conf:
KubernetesConf)
private val hasTemplate = conf.contains(KUBERNETES_EXECUTOR_PODTEMPLATE_FILE)
+ private val configmapName =
s"${conf.resourceNamePrefix}-$POD_TEMPLATE_CONFIGMAP"
Review comment:
During running the integration tests when watching the configmap it
looks something like this:
```
aaece65ef82e4a30b7b7800aad600d4f
spark-test-app-aac9f37502b2ca55-driver-conf-map 1 0s
aaece65ef82e4a30b7b7800aad600d4f
spark-test-app-aac9f37502b2ca55-driver-podspec-conf-map 1 0
```
For me this looks nice because it's clear that the confimap is used by the
driver. And when sorted alphabetically they are neatly together.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
