gemelen commented on pull request #29286: URL: https://github.com/apache/spark/pull/29286#issuecomment-705218033
@dongjoon-hyun > BTW, could you make another PR for mima change? We need to do that separately like [SPARK-26030](https://issues.apache.org/jira/browse/SPARK-26030) (Bump previousSparkVersion in MimaBuild.scala to be 2.4.0). > > ```scala > def mimaSettings(sparkHome: File, projectRef: ProjectRef): Seq[Setting[_]] = { > val organization = "org.apache.spark" > - val previousSparkVersion = "2.4.0" > + val previousSparkVersion = "3.0.0" > ``` I'm afraid that it's not viable: move to sbt 1.x requires to upgrade mima plugin (in fact it's a huge leap, from 0.3.0 to 0.8.0). Doing so without bumping version to check against for binary incompatibilities (ie master vs 2.4) generates more than a thousand of newly found hits, see details here - https://issues.apache.org/jira/browse/SPARK-32702 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
