HyukjinKwon commented on a change in pull request #29973:
URL: https://github.com/apache/spark/pull/29973#discussion_r501420104
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcFilterSuite.scala
##########
@@ -296,11 +295,6 @@ class HiveOrcFilterSuite extends OrcTest with
TestHiveSingleton {
test("filter pushdown - combinations with logical operators") {
withOrcDataFrame((1 to 4).map(i => Tuple1(Option(i)))) { implicit df =>
- // Because `ExpressionTree` is not accessible at Hive 1.2.x, this should
be checked
- // in string form in order to check filter creation including logical
operators
- // such as `and`, `or` or `not`. So, this function uses
`SearchArgument.toString()`
- // to produce string expression and then compare it to given string
expression below.
- // This might have to be changed after Hive version is upgraded.
Review comment:
Even if we can access `ExpressionTree` from `SearchArgument`, we can't
construct them to compare to use in tests. This seems what Hive does as well,
see
https://github.com/apache/hive/blob/master/ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
