maropu commented on a change in pull request #29939:
URL: https://github.com/apache/spark/pull/29939#discussion_r501423762
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
##########
@@ -46,7 +47,8 @@ class UnresolvedException[TreeType <: TreeNode[_]](tree:
TreeType, function: Str
case class UnresolvedRelation(
multipartIdentifier: Seq[String],
options: CaseInsensitiveStringMap = CaseInsensitiveStringMap.empty(),
- override val isStreaming: Boolean = false)
+ override val isStreaming: Boolean = false,
+ partitions: Seq[Partition] = Seq.empty[Partition])
Review comment:
IMHO adding it in `JDBCOptions` looks better than adding it in
`UnresolvedRelation` because the partition info is dedicated for JDBC scans and
having physical partition info in a class field of the logical plan is a bit
weird. But, its okay to wait for the comments of other reviewers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
