Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/5279#discussion_r27988958
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/DataTypeConversions.scala
---
@@ -20,24 +20,21 @@ package org.apache.spark.sql.types
import java.text.SimpleDateFormat
import org.apache.spark.sql.Row
-import org.apache.spark.sql.catalyst.ScalaReflection
-import org.apache.spark.sql.catalyst.expressions.GenericMutableRow
+import org.apache.spark.sql.catalyst.CatalystTypeConverters
+import org.apache.spark.sql.catalyst.expressions.GenericRowWithSchema
private[sql] object DataTypeConversions {
def productToRow(product: Product, schema: StructType): Row = {
--- End diff --
This is only used from LocalRelation AFAICT, but I think we should also add
a comment that this method is slow, and that users should use
CatalystTypeConverters.createToCatalystConverter for batch conversions -- we
don't want future contributors to rely on such a convenient method without at
least exposing the performance characteristics.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
