MaxGekk edited a comment on pull request #29972: URL: https://github.com/apache/spark/pull/29972#issuecomment-705382761
> For example, DB2 doesn't have a STRING type. It uses CHAR and VARCHAR. You could define a type in the common trait like `StrType`, and override in the Oracle and DB2 test suites. > Oracle allows update column data type from INTEGER to STRING, but DB2 doesn't allow update column data type from INTEGER to VARCHAR. ohh, I think we can remove such checks because: - I don't see any reasons to test DBMS behavior in Spark's tests - The checks doesn't improve test coverage. or as an option, we could extract dialect specific test to separate tests. For now, while reading the integration tests, it is hard to say why we duplicate the code. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
