Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/5236#issuecomment-91016008
@ilganeli this change looks great! Aside from the smaller comments I left
inline, I have two high level suggestions. The first is documentation. Without
this there is no way for the user to find out that they can use this new
notation for these configs. We should update the default values for all those
configs in `configuration.md` to use this notation, have a new section that
fully delineates all the options available.
The second is that I notice we do `Utils.getTimeAsS(conf.get(...))` a lot.
Since these conversions are designed for configs, would it make sense to have
`conf.getSeconds` and `conf.getMicroseconds` as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
