maropu commented on a change in pull request #29982:
URL: https://github.com/apache/spark/pull/29982#discussion_r502787723
##########
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala
##########
@@ -519,15 +519,29 @@ private[hive] class SparkSQLCLIDriver extends CliDriver
with Logging {
// Note: [SPARK-31595] if there is a `'` in a double quoted string, or a `"`
in a single quoted
// string, the origin implementation from Hive will not drop the trailing
semicolon as expected,
// hence we refined this function a little bit.
+ // Note: [SPARK-33110] Ignore the content inside C-style comment and ignore
the comment without
+ // content
private def splitSemiColon(line: String): JList[String] = {
var insideSingleQuote = false
var insideDoubleQuote = false
- var insideComment = false
+ var insideDashComment = false
+ var insideCStyleComment = false
+ var cStyleCommentRightBound = -1
Review comment:
The name `cStyle` looks weird, so could you use `bracketedComment`
instead?
https://github.com/apache/spark/blob/master/sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4#L1820-L1822
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
