Victsm commented on a change in pull request #29855:
URL: https://github.com/apache/spark/pull/29855#discussion_r502788031
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockHandler.java
##########
@@ -373,6 +427,54 @@ public ManagedBuffer next() {
}
}
+ /**
+ * Dummy implementation of merged shuffle file manager. Suitable for when
push-based shuffle
+ * is not enabled.
+ */
+ private static class NoOpMergedShuffleFileManager implements
MergedShuffleFileManager {
+
+ @Override
+ public StreamCallbackWithID receiveBlockDataAsStream(PushBlockStream msg) {
+ throw new UnsupportedOperationException("Cannot handle shuffle block
merge");
+ }
+
+ @Override
+ public MergeStatuses finalizeShuffleMerge(FinalizeShuffleMerge msg) throws
IOException {
+ throw new UnsupportedOperationException("Cannot handle shuffle block
merge");
+ }
+
+ @Override
+ public void registerApplication(String appId, String user) {
Review comment:
I'd prefer to resolve this comment for now, and revisit when it's more
clear what the requirement for a potentially more generic API would be.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
