srowen commented on a change in pull request #29995:
URL: https://github.com/apache/spark/pull/29995#discussion_r502935843
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/UnsafeArraySuite.scala
##########
@@ -72,9 +72,9 @@ class UnsafeArraySuite extends SparkFunSuite {
arrayData
}
- private def toUnsafeArray[T : TypeTag](array: Array[T]): ArrayData = {
+ private def toUnsafeArray[T: Manifest](array: Array[T]): ArrayData = {
val converted =
ExpressionEncoder[Array[T]].createSerializer().apply(array).getArray(0)
- assert(converted.isInstanceOf[T])
+ assert(manifest[T].runtimeClass.isInstance(converted))
Review comment:
OK I'm inclined to believe this assertion is just an error. It was
probably trying to test the element type, but it isn't. I think it could be
removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
