HyukjinKwon commented on a change in pull request #30008:
URL: https://github.com/apache/spark/pull/30008#discussion_r503013250
##########
File path: project/SparkBuild.scala
##########
@@ -756,12 +756,12 @@ object Assembly {
.getOrElse(SbtPomKeys.effectivePom.value.getProperties.get("hadoop.version").asInstanceOf[String])
},
assemblyJarName in assembly := {
- lazy val hdpVersion = hadoopVersion.value
+ lazy val versionValue = hadoopVersion.value
Review comment:
I think `hdp` was the short name of Hadoop instead of "Hortonworks Data
Platform" if you meant this but I think it's okay to fix to avoid confusion.
What about we name it `hadoopVersion` instead to make it extra explicit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
