WeichenXu123 commented on a change in pull request #29998:
URL: https://github.com/apache/spark/pull/29998#discussion_r503151315
##########
File path: python/pyspark/resource/profile.pyi
##########
@@ -22,7 +22,7 @@ from pyspark.resource.requests import ( # noqa: F401
TaskResourceRequest as TaskResourceRequest,
TaskResourceRequests as TaskResourceRequests,
)
-from typing import overload, Dict, Optional, Union
Review comment:
why change this ?
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/MicroBatchExecution.scala
##########
@@ -76,7 +76,7 @@ class MicroBatchExecution(
// transformation is responsible for replacing attributes with their final
values.
val disabledSources =
-
sparkSession.sqlContext.conf.disabledV2StreamingMicroBatchReaders.split(",")
+
Utils.stringToSeq(sparkSession.sqlContext.conf.disabledV2StreamingMicroBatchReaders)
Review comment:
why change this ?
##########
File path: project/SparkBuild.scala
##########
@@ -213,17 +213,23 @@ object SparkBuild extends PomBuild {
"gcs-maven-central-mirror" at
"https://maven-central.storage-download.googleapis.com/maven2/";,
DefaultMavenRepository,
Resolver.mavenLocal,
- Resolver.file("local", file(Path.userHome.absolutePath +
"/.ivy2/local"))(Resolver.ivyStylePatterns)
+ Resolver.file("ivyLocal", file(Path.userHome.absolutePath +
"/.ivy2/local"))(Resolver.ivyStylePatterns)
),
externalResolvers := resolvers.value,
otherResolvers := SbtPomKeys.mvnLocalRepository(dotM2 =>
Seq(Resolver.file("dotM2", dotM2))).value,
publishLocalConfiguration in MavenCompile := PublishConfiguration()
.withResolverName("dotM2")
.withArtifacts(packagedArtifacts.value.toVector)
.withLogging(ivyLoggingLevel.value),
+ publishLocalConfiguration in SbtCompile := PublishConfiguration()
+ .withResolverName("ivyLocal")
+ .withArtifacts(packagedArtifacts.value.toVector)
+ .withLogging(ivyLoggingLevel.value),
publishMavenStyle in MavenCompile := true,
+ publishMavenStyle in SbtCompile := false,
publishLocal in MavenCompile := publishTask(publishLocalConfiguration in
MavenCompile).value,
- publishLocalBoth := Seq(publishLocal in MavenCompile,
publishLocal).dependOn.value,
+ publishLocal in SbtCompile := publishTask(publishLocalConfiguration in
SbtCompile).value,
+ publishLocal := Seq(publishLocal in MavenCompile, publishLocal in
SbtCompile).dependOn.value,
Review comment:
why change this ?
##########
File path: project/plugins.sbt
##########
@@ -27,8 +27,6 @@ addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "0.15.0")
addSbtPlugin("com.typesafe.sbteclipse" % "sbteclipse-plugin" % "5.2.4")
-addSbtPlugin("net.virtual-void" % "sbt-dependency-graph" % "0.9.2")
-
Review comment:
why change this ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
