Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5460#discussion_r28183036
  
    --- Diff: R/pkg/inst/tests/test_binaryFile.R ---
    @@ -27,7 +27,7 @@ test_that("saveAsObjectFile()/objectFile() following 
textFile() works", {
       fileName2 <- tempfile(pattern="spark-test", fileext=".tmp")
       writeLines(mockFile, fileName1)
     
    -  rdd <- textFile(sc, fileName1)
    +  rdd <- textFile(sc, fileName1, 1)
    --- End diff --
    
    Not related to this PR but the `1` vs. `1L` thing (i.e. numeric vs. int) 
should also be standardized across all functions (they should accept numeric)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to