tgravescs commented on a change in pull request #29906:
URL: https://github.com/apache/spark/pull/29906#discussion_r503293173
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -722,74 +722,83 @@ package object config {
.booleanConf
.createWithDefault(true)
- // Blacklist confs
- private[spark] val BLACKLIST_ENABLED =
- ConfigBuilder("spark.blacklist.enabled")
+ private[spark] val EXCLUDE_ON_FAILURE_ENABLED =
+ ConfigBuilder("spark.excludeOnFailure.enabled")
.version("2.1.0")
Review comment:
ok, I guess if that is the case. Like I mentioned one of the other
renames didn't change this. I think it depends on if we are tracking the name
of the feature it controls with this? either way I think what we decide we
should document. There is also no documentation on the .version function in the
ConfigBuilder so we should really add something there ( I can if we agree up on
something). It ends up showing up on the documentation page under Since
Version so I guess looking at that we probably should update it as this rename
won't work on older version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
