srowen commented on a change in pull request #29995:
URL: https://github.com/apache/spark/pull/29995#discussion_r503319660
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/connector/InMemoryTable.scala
##########
@@ -114,18 +115,21 @@ class InMemoryTable(
case (micros: Long, TimestampType) =>
val localDate =
DateTimeUtils.microsToInstant(micros).atZone(UTC).toLocalDate
ChronoUnit.MONTHS.between(EPOCH_LOCAL_DATE, localDate)
+ case _ => throw new IllegalArgumentException("Match: unsupported
argument(s) type")
Review comment:
In these cases, why not put the value of the thing that wasn't matched
in the error?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
