cloud-fan commented on a change in pull request #29983:
URL: https://github.com/apache/spark/pull/29983#discussion_r503417842
##########
File path:
sql/core/src/test/resources/sql-tests/results/udf/postgreSQL/udf-aggregates_part1.sql.out
##########
@@ -141,17 +141,17 @@ struct<var_samp(CAST(CAST(udf(ansi_cast(ansi_cast(b as
decimal(38,0)) as string)
-- !query
SELECT udf(var_pop(1.0)), var_samp(udf(2.0))
-- !query schema
-struct<CAST(udf(ansi_cast(var_pop(ansi_cast(1.0 as double)) as string)) AS
DOUBLE):double,var_samp(CAST(CAST(udf(ansi_cast(2.0 as string)) AS
DECIMAL(2,1)) AS DOUBLE)):double>
+struct<CAST(udf(ansi_cast(var_pop(ansi_cast(1.0 as double), true) as string))
AS DOUBLE):double,var_samp(CAST(CAST(udf(ansi_cast(2.0 as string)) AS
DECIMAL(2,1)) AS DOUBLE)):double>
Review comment:
legacy config is internal and all the functions in one query should be
all legacy or not legacy. I think we don't need to display the legacy flag
value. We can override `stringArgs` in these functions (the base classes) to
exclude the legacy flag.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
