turboFei commented on a change in pull request #29982:
URL: https://github.com/apache/spark/pull/29982#discussion_r503948938
##########
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala
##########
@@ -519,15 +519,29 @@ private[hive] class SparkSQLCLIDriver extends CliDriver
with Logging {
// Note: [SPARK-31595] if there is a `'` in a double quoted string, or a `"`
in a single quoted
// string, the origin implementation from Hive will not drop the trailing
semicolon as expected,
// hence we refined this function a little bit.
+ // Note: [SPARK-33100] Ignore the content inside bracketed comment and
ignore the comment without
+ // content.
private def splitSemiColon(line: String): JList[String] = {
var insideSingleQuote = false
var insideDoubleQuote = false
- var insideComment = false
+ var insideDashComment = false
+ var insideBracketedComment = false
+ var bracketedCommentRightBound = -1
var escape = false
var beginIndex = 0
+ var contentBegin = false
Review comment:
It is a little difficult to recognize whether the statement begin.
For example:
```
/* comment */
\n
```
The "\n" is outside comment, but there is no statement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
