cloud-fan commented on a change in pull request #29831:
URL: https://github.com/apache/spark/pull/29831#discussion_r504397419
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala
##########
@@ -256,20 +256,21 @@ private[hive] trait HiveStrategies {
*/
object HiveTableScans extends Strategy {
def apply(plan: LogicalPlan): Seq[SparkPlan] = plan match {
- case ScanOperation(projectList, predicates, relation: HiveTableRelation)
=>
+ case ScanOperation(projectList, filters, relation: HiveTableRelation) =>
// Filter out all predicates that only deal with partition keys, these
are given to the
// hive table scan operator to be used for partition pruning.
val partitionKeyIds = AttributeSet(relation.partitionCols)
- val (pruningPredicates, otherPredicates) = predicates.partition {
predicate =>
- !predicate.references.isEmpty &&
- predicate.references.subsetOf(partitionKeyIds)
- }
+ val normalizedFilters = DataSourceStrategy.normalizeExprs(
+ filters.filter(_.deterministic), relation.output)
+
+ val partitionKeyFilters =
DataSourceStrategy.getPushedDownFilters(relation.partitionCols,
+ normalizedFilters)
pruneFilterProject(
projectList,
- otherPredicates,
+ filters.filter(f => f.references.isEmpty ||
!f.references.subsetOf(partitionKeyIds)),
Review comment:
It's OK for now to be the same as before, but it's better to make it
consistent with `FileSourceStrategy`. We can do it in followup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
