fsamuel-bs commented on a change in pull request #29977:
URL: https://github.com/apache/spark/pull/29977#discussion_r504768749
##########
File path: core/src/main/scala/org/apache/spark/scheduler/Task.scala
##########
@@ -123,8 +125,12 @@ private[spark] abstract class Task[T](
Option(taskAttemptId),
Option(attemptNumber)).setCurrentContext()
+ plugins.foreach(_.onTaskStart())
Review comment:
We catch Throwable on `ExecutorPluginContainer#onTaskStart` and siblings
(see
https://github.com/apache/spark/pull/29977/files#diff-5e4d939e9bb53b4be2c48d4eb53b885c162c729b9adc874f918f7701a352cdbbR157),
so that's what I meant by "not propagate". I.e. if a plugin's `onTaskStart`
throws, Spark will log, but won't fail the associated spark task.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
