HeartSaVioR opened a new pull request #30043:
URL: https://github.com/apache/spark/pull/30043


   ### What changes were proposed in this pull request?
   
   This PR proposes to fix a bug on calling 
`DataType.equalsIgnoreCompatibleNullability` with mistakenly swapped parameters 
in `AppendData.outputResolved`. The order of parameters for 
`DataType.equalsIgnoreCompatibleNullability` are `from` and `to`, which says 
that the right order of matching variables are `inAttr` and `outAttr`.
   
   ### Why are the changes needed?
   
   Although the problematic part is a dead code, once we know there's a bug, 
preferably we'd like to fix that.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, as this fixes the dead code.
   
   ### How was this patch tested?
   
   This patch fixes the dead code, which is not easy to craft a test. (The test 
in original commit is no longer valid here.)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to