huaxingao commented on a change in pull request #30041:
URL: https://github.com/apache/spark/pull/30041#discussion_r505669033
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalogSuite.scala
##########
@@ -199,8 +199,8 @@ class JDBCTableCatalogSuite extends QueryTest with
SharedSparkSession {
test("alter table ... rename column") {
withTable("h2.test.alt_table") {
- sql("CREATE TABLE h2.test.alt_table (ID INTEGER, C0 INTEGER) USING _")
- sql("ALTER TABLE h2.test.alt_table RENAME COLUMN ID TO C")
+ sql("CREATE TABLE h2.test.alt_table (id INTEGER, C0 INTEGER) USING _")
+ sql("ALTER TABLE h2.test.alt_table RENAME COLUMN id TO C")
Review comment:
Yes, upper case `ID` still works here. I will add tests for case
insensitive column resolution.
Thanks for reviewing and merging my PR!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
