Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4135#discussion_r28024103
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/ReceiverSuite.scala ---
@@ -295,6 +334,27 @@ class ReceiverSuite extends TestSuiteBase with
Timeouts with Serializable {
}
/**
+ * An implementation of Task running a NetworkReceiver used for testing
whether
+ * we can start/stop receiver properly.
+ */
+ class FakeReceiverTask(
+ stageId: Int,
+ executor: FakeReceiverSupervisor,
+ prefLocs: Seq[TaskLocation] = Nil) extends Task[Unit](stageId, 0) {
--- End diff --
It looks like we never call this with a non-Nil value of `prefLocs`, so we
can probably drop the constructor argument and just hardcode `Nil` into the
`preferredLocations` method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
