dongjoon-hyun commented on a change in pull request #30059:
URL: https://github.com/apache/spark/pull/30059#discussion_r505898511
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -128,41 +124,17 @@ jobs:
uses: actions/setup-java@v1
with:
java-version: ${{ matrix.java }}
- # PySpark
- - name: Install PyPy3
- # Note that order of Python installations here matters because default
python3 is
- # overridden by pypy3.
- uses: actions/setup-python@v2
- if: contains(matrix.modules, 'pyspark')
- with:
- python-version: pypy3
- architecture: x64
- - name: Install Python 3.6
- uses: actions/setup-python@v2
- if: contains(matrix.modules, 'pyspark')
- with:
- python-version: 3.6
- architecture: x64
- name: Install Python 3.8
uses: actions/setup-python@v2
# We should install one Python that is higher then 3+ for SQL and Yarn
because:
# - SQL component also has Python related tests, for example,
IntegratedUDFTestUtils.
# - Yarn has a Python specific test too, for example, YarnClusterSuite.
- if: contains(matrix.modules, 'yarn') || contains(matrix.modules,
'pyspark') || (contains(matrix.modules, 'sql') && !contains(matrix.modules,
'sql-'))
+ if: contains(matrix.modules, 'yarn') || (contains(matrix.modules, 'sql')
&& !contains(matrix.modules, 'sql-'))
with:
python-version: 3.8
architecture: x64
- - name: Install Python packages (Python 3.6 and PyPy3)
- if: contains(matrix.modules, 'pyspark')
- # PyArrow is not supported in PyPy yet, see ARROW-2651.
- run: |
- python3.6 -m pip install numpy pyarrow pandas scipy xmlrunner
- python3.6 -m pip list
- # PyPy does not have xmlrunner
- pypy3 -m pip install numpy pandas scipy
- pypy3 -m pip list
- name: Install Python packages (Python 3.8)
- if: contains(matrix.modules, 'pyspark') || (contains(matrix.modules,
'sql') && !contains(matrix.modules, 'sql-'))
+ if: (contains(matrix.modules, 'sql') && !contains(matrix.modules,
'sql-'))
run: |
python3.8 -m pip install numpy pyarrow pandas scipy xmlrunner
Review comment:
Hi, @viirya
`Python 3.8` is not the target of this PR because it doesn't consume any
time (it's zero seconds).
In addition to that, I want to keep it here without touching it. When we
switch `Scala/Java` tests into `pre-built image`, it will use the shared python
libraries on the image in any way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
