srowen commented on a change in pull request #29906:
URL: https://github.com/apache/spark/pull/29906#discussion_r505997016
##########
File path: core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala
##########
@@ -431,23 +481,23 @@ abstract class SparkListener extends
SparkListenerInterface {
override def onExecutorRemoved(executorRemoved:
SparkListenerExecutorRemoved): Unit = { }
- override def onExecutorBlacklisted(
- executorBlacklisted: SparkListenerExecutorBlacklisted): Unit = { }
+ override def onExecutorExcluded(
+ executorExcluded: SparkListenerExecutorExcluded): Unit = { }
- def onExecutorBlacklistedForStage(
- executorBlacklistedForStage: SparkListenerExecutorBlacklistedForStage):
Unit = { }
+ override def onExecutorExcludedForStage(
+ executorExcludedForStage: SparkListenerExecutorExcludedForStage): Unit =
{ }
- def onNodeBlacklistedForStage(
- nodeBlacklistedForStage: SparkListenerNodeBlacklistedForStage): Unit = {
}
+ override def onNodeExcludedForStage(
+ nodeExcludedForStage: SparkListenerNodeExcludedForStage): Unit = { }
- override def onExecutorUnblacklisted(
- executorUnblacklisted: SparkListenerExecutorUnblacklisted): Unit = { }
+ override def onExecutorUnexcluded(
+ executorUnexcluded: SparkListenerExecutorUnexcluded): Unit = { }
- override def onNodeBlacklisted(
- nodeBlacklisted: SparkListenerNodeBlacklisted): Unit = { }
+ override def onNodeExcluded(
+ nodeExcluded: SparkListenerNodeExcluded): Unit = { }
- override def onNodeUnblacklisted(
- nodeUnblacklisted: SparkListenerNodeUnblacklisted): Unit = { }
+ override def onNodeUnexcluded(
+ nodeUnexcluded: SparkListenerNodeUnexcluded): Unit = { }
Review comment:
Also catching up, but, yes please merely deprecate things not remove
them as part of this, where they could possibly be called or extended by apps
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
