sunchao commented on a change in pull request #29843:
URL: https://github.com/apache/spark/pull/29843#discussion_r506671572
##########
File path: pom.xml
##########
@@ -2393,17 +2435,6 @@
</rules>
</configuration>
</execution>
- <execution>
Review comment:
I had to remove this because the current approach relies on multiple
`hadoop-client` dependencies when Hadoop profile is 2.7. Not sure if there is a
way to exclude certain dependencies from this enforcer.
##########
File path: pom.xml
##########
@@ -2863,6 +2894,7 @@
<artifactId>maven-shade-plugin</artifactId>
<configuration>
<shadedArtifactAttached>false</shadedArtifactAttached>
+ <createDependencyReducedPom>false</createDependencyReducedPom>
Review comment:
This is to avoid a [potential
bug](https://issues.apache.org/jira/browse/MSHADE-148) in Maven where it could
stuck in an infinite loop when generating reduced pom.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
