Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/5434#discussion_r28042811
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/ui/StreamingPage.scala ---
@@ -189,5 +190,21 @@ private[ui] class StreamingPage(parent: StreamingTab)
}
UIUtils.listingTable(headers, generateDataRow, data, fixedWidth = true)
}
+
+ private def generateBatchListTables(): Seq[Node] = {
+ val runningBatches =
listener.runningBatches.sortBy(_.batchTime.milliseconds).reverse
+ val waitingBatches =
listener.waitingBatches.sortBy(_.batchTime.milliseconds).reverse
+ var content =
--- End diff --
This is a little hard to read. Please rearrange the code a little bit. Also
better to not use var. Rather
```
val activeBatchesContent = {
<h4 id="active">Active Batches ({runningBatches.size +
waitingBatches.size})</h4> ++
new ActiveBatchTable(runningBatches, waitingBatches).toNodeSeq
}
val completedBatchesContent = {
...
}
...
activeBatchesContent ++ completedBatchesContent
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
