mridulm commented on a change in pull request #29977:
URL: https://github.com/apache/spark/pull/29977#discussion_r506786690
##########
File path:
core/src/test/scala/org/apache/spark/internal/plugin/PluginContainerSuite.scala
##########
@@ -129,6 +129,38 @@ class PluginContainerSuite extends SparkFunSuite with
BeforeAndAfterEach with Lo
assert(TestSparkPlugin.driverPlugin != null)
}
+ test("SPARK-33088: executor tasks trigger plugin calls") {
+ val conf = new SparkConf()
+ .setAppName(getClass().getName())
+ .set(SparkLauncher.SPARK_MASTER, "local[1]")
+ .set(PLUGINS, Seq(classOf[TestSparkPlugin].getName()))
+
+ sc = new SparkContext(conf)
+ sc.parallelize(1 to 10, 2).count()
+
+ assert(TestSparkPlugin.executorPlugin.numOnTaskStart == 2)
+ assert(TestSparkPlugin.executorPlugin.numOnTaskSucceeded == 2)
+ assert(TestSparkPlugin.executorPlugin.numOnTaskFailed == 0)
+ }
+
+ test("SPARK-33088: executor failed tasks trigger plugin calls") {
+ val conf = new SparkConf()
+ .setAppName(getClass().getName())
+ .set(SparkLauncher.SPARK_MASTER, "local[1]")
+ .set(PLUGINS, Seq(classOf[TestSparkPlugin].getName()))
+
+ sc = new SparkContext(conf)
+ try {
+ sc.parallelize(1 to 10, 2).foreach(i => throw new RuntimeException)
+ } catch {
+ case t: Throwable => // ignore exception
+ }
+
+ assert(TestSparkPlugin.executorPlugin.numOnTaskStart == 2)
+ assert(TestSparkPlugin.executorPlugin.numOnTaskSucceeded == 0)
+ assert(TestSparkPlugin.executorPlugin.numOnTaskFailed == 2)
Review comment:
Thanks @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
