viirya commented on a change in pull request #26935:
URL: https://github.com/apache/spark/pull/26935#discussion_r507022428
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala
##########
@@ -36,10 +36,14 @@ import org.apache.spark.sql.types.StructType
import org.apache.spark.util.{ThreadUtils, Utils}
/**
- * Base trait for a versioned key-value store. Each instance of a `StateStore`
represents a specific
- * version of state data, and such instances are created through a
[[StateStoreProvider]].
+ * Base trait for a versioned key-value store which provides read operations.
Each instance of a
+ * `StateStore` represents a specific version of state data, and such
instances are created
Review comment:
`StateStore represents ...` -> `ReadStateStore represents ...`?
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala
##########
@@ -81,6 +74,43 @@ trait StateStore {
iterator()
}
+ /**
+ * Return an iterator containing all the key-value pairs in the StateStore.
Implementations must
+ * ensure that updates (puts, removes) can be made while iterating over this
iterator.
Review comment:
`Implementations must ensure that updates ...`, but `ReadStateStore`
doesn't support puts, removes, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
