imback82 commented on a change in pull request #30079:
URL: https://github.com/apache/spark/pull/30079#discussion_r507208852
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/PlanResolutionSuite.scala
##########
@@ -160,6 +160,8 @@ class PlanResolutionSuite extends AnalysisTest {
new ResolveCatalogs(catalogManager),
new ResolveSessionCatalog(catalogManager, conf, _ == Seq("v"), _ =>
false),
analyzer.ResolveTables,
+ analyzer.ResolveUnresolvedTableOrView,
+ new ResolveSessionCatalog(catalogManager, conf, _ == Seq("v"), _ =>
false),
Review comment:
Unfortunately, we need to run `ResolveSessionCatalog` again if we want
to test the resolution to `DropTableCommand`:
https://github.com/apache/spark/pull/30079/files#diff-7ce7e7e03723d865798a6dcb6efa81aea25e925397e4c9288bbfd3317c8a515bR642
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
