Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5144#discussion_r28026301
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcher.scala 
---
    @@ -0,0 +1,207 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.deploy.mesos
    +
    +import java.io.File
    +import java.util.concurrent.CountDownLatch
    +
    +import org.apache.spark
    +import 
org.apache.spark.deploy.mesos.MesosClusterDispatcher.ClusterDispatcherArguments
    +import org.apache.spark.deploy.mesos.ui.MesosClusterUI
    +import org.apache.spark.deploy.rest.mesos.MesosRestServer
    +import org.apache.spark.scheduler.cluster.mesos._
    +import org.apache.spark.util.{IntParam, SignalLogger, Utils}
    +import org.apache.spark.{Logging, SecurityManager, SparkConf}
    +
    +/*
    + * A dispatcher that is responsible for managing and launching drivers, 
and is intended to
    + * be used for Mesos cluster mode. The dispatcher is launched by the user 
in the cluster,
    + * which it launches a [[MesosRestServer]] for listening for driver 
requests, and launches a
    + * [[MesosClusterScheduler]] to launch these drivers in the Mesos cluster.
    + *
    + * A typical new driver lifecycle is the following:
    + *
    + * - Driver submitted via spark-submit talking to the [[MesosRestServer]]
    + * - [[MesosRestServer]] queues the driver request to 
[[MesosClusterScheduler]]
    + * - [[MesosClusterScheduler]] gets resource offers and launches the 
drivers that are in queue
    + *
    + * This dispatcher supports both Mesos fine-grain or coarse-grain mode as 
the mode is configurable
    + * per driver launched.
    + * This class is needed since Mesos doesn't manage frameworks, so the 
dispatcher acts as
    + * a daemon to launch drivers as Mesos frameworks upon request.
    + */
    +private[mesos] class MesosClusterDispatcher(
    +    args: ClusterDispatcherArguments,
    +    conf: SparkConf)
    +  extends Logging {
    +
    +  private def publicAddress(conf: SparkConf, host: String): String = {
    +    val envVar = conf.getenv("SPARK_PUBLIC_DNS")
    +    if (envVar != null) envVar else host
    +  }
    +
    +  private val recoveryMode = conf.get("spark.deploy.recoveryMode", 
"NONE").toUpperCase()
    --- End diff --
    
    I searched the codebase and looks like we've so far reserved the 
`spark.deploy.*` namespace for standalone mode only. If we want to support 
recovery in Mesos we should put these under the `spark.mesos.*` namespace 
instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to