AngersZhuuuu commented on a change in pull request #30057:
URL: https://github.com/apache/spark/pull/30057#discussion_r507382927
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala
##########
@@ -139,6 +140,34 @@ case class InsertIntoHadoopFsRelationCommand(
}
if (doInsertion) {
+ // For dynamic partition overwrite, we do not delete partition
directories ahead.
Review comment:
> I believe `InsertIntoHadoopFsRelationCommand` already deletes
partition directories before reaching this point.
Yes, it's a problem. As mentioned in
https://github.com/apache/spark/pull/30057#discussion_r506791318.
Maybe we add a check before execute is best. But in that way we can't
support dynamicPartitionFilter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
