dongjoon-hyun edited a comment on pull request #30051: URL: https://github.com/apache/spark/pull/30051#issuecomment-712410420
Hey, @HeartSaVioR . I don't think the revert of revert is a correct way here. At least, if you really want to `revert of revert`, you should make a PR and pass the UT in the community instead of silent reverting of reverting. 02f80cf293 Revert "Revert "[SPARK-33146][CORE] Check for non-fatal errors when loading new applications in SHS"" The way I see this is the following. 1. The original commit was wrong because it's committed without testing. 2. Hence, the revert is legitimate to recover `branch-3.0`. 3. After you tweaks `branch-3.0` yesterday, you cannot claim of `revert of revert`. Instead, you had better land SPARK-33146 as a normal backporting PR with `[3.0]` tag. In general, `Revert of revert` is used when the first revert decision was wrong. Here, it looks like you use it as a claim that your first commit was right. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
