HeartSaVioR commented on a change in pull request #30076:
URL: https://github.com/apache/spark/pull/30076#discussion_r508092673
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -151,7 +151,7 @@ case class StreamingSymmetricHashJoinExec(
stateWatermarkPredicates = JoinStateWatermarkPredicates(),
stateFormatVersion, left, right)
}
- if (stateFormatVersion < 2 && joinType != Inner) {
+ if (stateFormatVersion < 2 && (joinType == LeftOuter || joinType ==
RightOuter)) {
Review comment:
In practice it shouldn't be occurred. Changing the state format version
is not something we want to expose to end users - making it as config is merely
for convenience, if I'm not missing something.
Please consider my comment as a kind of defensive programming - left semi
doesn't work with state format version 1, hence we prevent it. Nothing much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
