maropu commented on a change in pull request #30018:
URL: https://github.com/apache/spark/pull/30018#discussion_r508952294
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##########
@@ -249,6 +237,41 @@ trait PredicateHelper extends Logging {
}
}
+/**
+ * Helper methods for collecting and replacing aliases.
+ */
+trait AliasHelper {
Review comment:
How about moving this trait into a new file like `AliasHelper.scala`? It
looks more general now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
